create container before inserting to typeIndex (#4)

* create container before inserting to typeIndex * fix tests for registerInTypeIndex
pondersource · Jan 9, 2024 · 8076925 · 8076925
1 parent 206685e
commit 8076925
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rezasoltani/solid-typeindex-support",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "description": "",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

diff --git a/src/TypeIndexHelper.ts b/src/TypeIndexHelper.ts
@@ -3,6 +3,7 @@ import {
     ThingPersisted,
     addNamedNode,
     buildThing,
+    createSolidDataset,
     createThing,
     getNamedNode,
     getSolidDataset,
@@ -196,23 +197,19 @@ export class TypeIndexHelper {
     ): Promise<SolidDataset> {
         const typeIndex = await this.getTypeIndex(webId, fetch, isPrivate);
 
-        const typeIndexDS = await getSolidDataset(typeIndex?.value, {
-            fetch,
-        });
+        const typeIndexDS = await getSolidDataset(typeIndex?.value, { fetch });
 
-        const registeryThing = buildThing(
-            createThing({ name: typeRegistrationTitle })
-        )
+        const registeryThing = buildThing(createThing({ name: typeRegistrationTitle }))
             .addNamedNode(__forClass, namedNode(rdfClass))
             .addNamedNode(isContainer ? __solid_instance_container : __solid_instance, namedNode(registeryUrl))
             .addUrl(RDF.type, __solidTypeRegistration)
             .build();
 
         const updatedTypeIndexDS = setThing(typeIndexDS, registeryThing);
 
-        return await saveSolidDatasetAt(typeIndex?.value, updatedTypeIndexDS, {
-            fetch,
-        });
+        await saveSolidDatasetAt(registeryUrl, createSolidDataset(), { fetch });
+
+        return await saveSolidDatasetAt(typeIndex?.value, updatedTypeIndexDS, { fetch });
     }
 
 

diff --git a/test/unit/TypeIndexHelper.test.ts b/test/unit/TypeIndexHelper.test.ts
@@ -146,6 +146,7 @@ describe("registerInTypeIndex", () => {
         jest.spyOn(TypeIndexHelper, 'getTypeIndex').mockResolvedValueOnce(namedNode(privateTypeIndexPath));
         jest.spyOn(inruptSOLIDClient, "getSolidDataset").mockResolvedValue(loadFixture("privateTypeIndexDS.json"));
         jest.spyOn(inruptSOLIDClient, 'setThing').mockReturnValueOnce(loadFixture("privateTypeIndexDS.json"));
+        jest.spyOn(inruptSOLIDClient, 'saveSolidDatasetAt').mockResolvedValueOnce(loadFixture("createRegisteryDS.json"));
         jest.spyOn(inruptSOLIDClient, 'saveSolidDatasetAt').mockResolvedValueOnce(loadFixture("privateTypeIndexDS.json"));
 
         const res = await TypeIndexHelper.registerInTypeIndex(session.info.webId, "bookmarks", BOOKMARK.bookmarks, session.fetch, indexUrl, isContainer, isPrivate);
@@ -164,6 +165,7 @@ describe("registerInTypeIndex", () => {
         jest.spyOn(TypeIndexHelper, 'getTypeIndex').mockResolvedValueOnce(namedNode(privateTypeIndexPath));
         jest.spyOn(inruptSOLIDClient, "getSolidDataset").mockResolvedValue(loadFixture("publicTypeIndexDS.json"));
         jest.spyOn(inruptSOLIDClient, 'setThing').mockReturnValueOnce(loadFixture("publicTypeIndexDS.json"));
+        jest.spyOn(inruptSOLIDClient, 'saveSolidDatasetAt').mockResolvedValueOnce(loadFixture("createRegisteryDS.json"));
         jest.spyOn(inruptSOLIDClient, 'saveSolidDatasetAt').mockResolvedValueOnce(loadFixture("publicTypeIndexDS.json"));
 
         const res = await TypeIndexHelper.registerInTypeIndex(session.info.webId, "bookmarks", BOOKMARK.bookmarks, session.fetch, indexUrl, isContainer, isPrivate);

diff --git a/test/unit/fixtures/createRegisteryDS.json b/test/unit/fixtures/createRegisteryDS.json
@@ -0,0 +1,16 @@
+{
+    "type": "Dataset",
+    "graphs": {
+        "default": {}
+    },
+    "internal_changeLog": {
+        "additions": [],
+        "deletions": []
+    },
+    "internal_resourceInfo": {
+        "sourceIri": "https://fake-pod.net/bookmarks/",
+        "isRawData": false,
+        "contentType": "text/plain; charset=utf-8",
+        "linkedResources": {}
+    }
+}