-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support #67
Conversation
Adds a Windows build script `make.ps1` and updates the code and tests to work on Windows.
Hi @kulibali, The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
This will need to wait for ponylang/ponyc#3817 and ponylang/ponyc#3816 |
Also renamed `client.pony` to `http_client.pony` to conform to the style guide.
.gitignore
Outdated
@@ -4,3 +4,5 @@ | |||
TAGS | |||
tags | |||
.coverage/ | |||
.vscode | |||
lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks
Gordon made changes to TCP that is in nightlies that needs to be tested as well.
@kulibali I pushed an update to run on latest ponyc as well to get recent tcp changes, but nightly wont have all the changes until tomorrow so we should do a fake change tomorrow to get this to run then as well. |
@kulibali can you undo the "kick ci commit" and then this can be merged? |
This reverts commit 6c2f1f2.
@SeanTAllen should be good to merge now. |
Adds a Windows build script
make.ps1
and updates the code and tests to work on Windows.