Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support #67

Merged
merged 8 commits into from
Sep 1, 2021
Merged

Add Windows support #67

merged 8 commits into from
Sep 1, 2021

Conversation

chalcolith
Copy link
Member

Adds a Windows build script make.ps1 and updates the code and tests to work on Windows.

Adds a Windows build script `make.ps1` and updates the code and tests to work on Windows.
@chalcolith chalcolith added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Aug 3, 2021
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 67.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@chalcolith
Copy link
Member Author

This will need to wait for ponylang/ponyc#3817 and ponylang/ponyc#3816

@chalcolith chalcolith added the do not merge This PR should not be merged at this time label Aug 3, 2021
@SeanTAllen SeanTAllen changed the title Build http for Windows Add Windows support Aug 3, 2021
Also renamed `client.pony` to `http_client.pony` to conform to the style guide.
@chalcolith chalcolith removed the do not merge This PR should not be merged at this time label Aug 16, 2021
.gitignore Outdated
@@ -4,3 +4,5 @@
TAGS
tags
.coverage/
.vscode
lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a newline here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

chalcolith and others added 3 commits August 16, 2021 13:00
Gordon made changes to TCP that is in nightlies that needs to be tested
as well.
@SeanTAllen
Copy link
Member

@kulibali I pushed an update to run on latest ponyc as well to get recent tcp changes, but nightly wont have all the changes until tomorrow so we should do a fake change tomorrow to get this to run then as well.

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Aug 17, 2021
@chalcolith chalcolith removed the do not merge This PR should not be merged at this time label Aug 25, 2021
@SeanTAllen
Copy link
Member

@kulibali can you undo the "kick ci commit" and then this can be merged?

@chalcolith
Copy link
Member Author

@SeanTAllen should be good to merge now.

@SeanTAllen SeanTAllen merged commit 20a4b31 into main Sep 1, 2021
@SeanTAllen SeanTAllen deleted the windows_build branch September 1, 2021 16:53
github-actions bot pushed a commit that referenced this pull request Sep 1, 2021
github-actions bot pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants