-
-
Notifications
You must be signed in to change notification settings - Fork 18
Resolve Local Dependencies From Bundle Path #78
Conversation
@rawkode looks like there is a test failure. |
8e4f3b1
to
c5e762a
Compare
c5e762a
to
82e8d39
Compare
Hi @SeanTAllen, This should build successfully now. One thing I'd appreciate some guidance on though: The following works, without error: Path.join(tmp.path, "../local/a") + ":" + but the following fails: tmp.join("../local/a")?.path Which I find strange, as the following works: ```pony
tmp.join("./local/a")?.path I don't understand why 😕 Is this a bug in the |
path = match base
| let b: FilePath =>
if not b.caps(FileLookup) then
error
end
let tmp_path = Path.join(b.path, path')
caps.intersect(b.caps)
if not tmp_path.at(b.path, 0) then
error
end
tmp_path
| let b: AmbientAuth =>
Path.abs(path')
end |
@SeanTAllen I believe this PR is good to go, regardless of my question (Hopefully 👍 ) |
Before this is merged, we need a good release message for this as it is a breaking change. @rawkode do you feel up to writing that? If yes, have a go and put it in a comment here. Ideally, we'd want an explanation of what changed, why, and before and after examples of what what one would need to change (if applicable). |
Resolve Local Dependencies From Bundle Path Previously, if a Now, all relative dependencies are resolved relatively from the This resolution is more intuitive and predictable. |
|
Thanks @rawkode |
Fixes #22