Finalisers on embed fields don't get run

[dipinhora]

Finalisers do not get run for embeds.

@sylvanc pointed out that this might be an issue. I verified it by extending the minimal-cases/finalisers code to confirm.

The following code:

primitive PrimitiveInitFinal
  fun _init() =>
    @printf[I32]("primitive init\n".cstring())

  fun _final() =>
    @printf[I32]("primitive final\n".cstring())

class ClassFinal
  embed f: EmbedFinal = EmbedFinal

  fun _final() =>
    @printf[I32]("class final\n".cstring())

class EmbedFinal
  fun _final() =>
    @printf[I32]("embed final\n".cstring())

actor Main
  new create(env: Env) =>
    ClassFinal

  fun _final() =>
    @printf[I32]("actor final\n".cstring())

Produces the following output when run:

$ ./finalisers 
primitive init
actor final
class final
primitive final

If the embed in ClassFinal is changed to a var or let the following output is produced:

$ ./finalisers 
primitive init
actor final
class final
embed final
primitive final

[Praetonus]

I think the most straightforward way to fix this is to add calls to embedded fields finalisers in the enclosing objects' finalisers. That would be in the genfun_fun function in genfun.c, where a special case should be added if the function being generated is a finaliser (i.e. if its name is _final).