Set null terminator in String.from_iso_array (issue #1435) #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `Array[U8]` passed to `String.from_iso_array` has pre-allocated space, the first pre-allocated bit (the one at the `_size` index) should be set to `0` in order to be compliant with how `is_null_terminated` does its check. This PR sets that bit in such a case.
|
One of the tests is commented out because it relies on the |
Perelandric
changed the title
|
Apparent unrelated failure on Travis with: |
|
The linker failure above that is disturbing. I'll restart the build to see if it fails again. |
|
Thanks @Praetonus, looks like that did the trick. |
jemc
added
the
changelog - fixed
|
@Perelandric thanks for going down this rabbit hole and taking care of these issues! It's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Array[U8]passed toString.from_iso_arrayhas pre-allocatedspace, the first pre-allocated byte (the one at the
_sizeindex) shouldbe set to
0in order to be compliant with howis_null_terminateddoes its check. This PR sets that byte in such a case.
Fixes #1435