Register the thread calling pony_init #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the thread initialising the runtime would use the runtime context of one of the scheduler threads. Now that the pony_unregister_thread function exists and is freeing the runtime context of the schedulers when the runtime exits, the initialising thread must have its own context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the thread initialising the runtime would use the runtime context of one of the scheduler threads. Now that the pony_unregister_thread function exists and is freeing the runtime context of the schedulers when the runtime exits, the initialising thread must have its own context.
This should fix the segfault encountered by #1629.