rfc: require programmer to implement network failure handling #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kcrimson i havent had a chance to look at the changes in this yet. can you amend your commit comment and force push? the amended commit comment would reference the RFC by number for future reference (#23) and ideally, include the motivation: |
…enarios with their network code. TCPConnectionNotify, UDPNotify and TCPListenNotify will all, by default, silently eat connection failures.
kcrimson
force-pushed
the
network_failure_handling
branch
from
b84d55f
to
e5bc69d
Compare
|
@SeanTAllen comments updated |
SeanTAllen
reviewed
May 3, 2017
| fun ref connect_failed(conn: TCPConnection ref) => | ||
| _h.fail_action("receiver connect failed") | ||
|
|
||
|
|
There was a problem hiding this comment.
extra space. can remove in post.
SeanTAllen
reviewed
May 3, 2017
| @@ -38,7 +41,7 @@ actor TCPListener | |||
| var _max_size: USize | |||
|
|
|||
| new create(auth: TCPListenerAuth, notify: TCPListenNotify iso, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
There was a problem hiding this comment.
extra space at end added. can remove in post.
SeanTAllen
reviewed
May 3, 2017
| @@ -54,7 +57,7 @@ actor TCPListener | |||
| _notify_listening() | |||
|
|
|||
| new ip4(auth: TCPListenerAuth, notify: TCPListenNotify iso, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
There was a problem hiding this comment.
extra space at end added. can remove in post.
SeanTAllen
reviewed
May 3, 2017
| @@ -70,7 +73,7 @@ actor TCPListener | |||
| _notify_listening() | |||
|
|
|||
| new ip6(auth: TCPListenerAuth, notify: TCPListenNotify iso, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
| host: String = "", service: String = "0", limit: USize = 0, | |||
There was a problem hiding this comment.
extra space at end added. can remove in post.
|
thanks @kcrimson |
SeanTAllen
added a commit
that referenced
this pull request
May 6, 2017
PR #1853 changed `TCPConnectionNotify` not `TCPConnection`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is second attempt to this PR.