Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: assert failure on explicit reference to this in constructor. #1867

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Fix: assert failure on explicit reference to this in constructor. #1867

merged 1 commit into from
Apr 26, 2017

Conversation

jemc
Copy link
Member

@jemc jemc commented Apr 26, 2017

Resolves #1865.

@SeanTAllen
Copy link
Member

@jemc i don't consider this a "must release now" but am open to the idea that it should be a "release now". i think it's right on the edge. thoughts?

@jemc
Copy link
Member Author

jemc commented Apr 26, 2017

I'm not sure either way. We can probably hold off for a short while and wait for a few other fixes to come in.

@sylvanc sylvanc merged commit 68e6c45 into master Apr 26, 2017
@jemc jemc deleted the fix/explicit-this-constructor branch April 26, 2017 19:34
jemc added a commit that referenced this pull request Apr 26, 2017
@jemc
Update CHANGELOG for PR #1867.
b1d77f0
@jemc
Copy link
Member Author

jemc commented Apr 26, 2017

Forgot to add the changelog tag to this one, so I updated the changelog in b1d77f0.

@plietar plietar mentioned this pull request May 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jemc @SeanTAllen @sylvanc