Fix bug in as capture
#1981
Fix bug in as capture
#1981
Conversation
Theodus
added
changelog - fixed
There was a problem hiding this comment.
Could you add a new test case demonstrating the fix?
Also, the actual rules for consume ! should be removed. This is in consume_single in alias.c:154. I think an assertion checking that ccap is a capability and not TK_ALIASED should be added as well in case there are other parts of the compiler using consume !.
I'd also like to have @sylvanc's opinion before merging since he probably knows why consume ! was added in the first place and we could be missing the point here by simply removing it.
|
One situation where removing this becomes problematic is that it removes a workaround for the situation in issue #1987 where |
Theodus
added
do not merge
| @@ -461,6 +461,7 @@ bool expr_case(pass_opt_t* opt, ast_t* ast) | |||
| ast_error(opt->check.errors, pattern, "this pattern can never match"); | |||
| ast_error_continue(opt->check.errors, match_type, "match type: %s", | |||
| ast_print_type(operand_type)); | |||
| // TODO report unaliased type when body is consume ! | |||
There was a problem hiding this comment.
Were you intending to resolve this TODO before merging?
There was a problem hiding this comment.
I tried, but I couldn't figure out an easy way of reporting an 'unaliased' type.
There was a problem hiding this comment.
This looks like another case where the "deferred error context" discussed during this week's sync and summarised in #1972 could be useful.
Theodus
dismissed
Praetonus’s stale review
The fix now reflects what was discussed during the sync meeting
| TEST_ERRORS_1(src, "this capture violates capabilities"); | ||
| } | ||
|
|
||
| TEST_F(BadPonyTest, AsUnaliased) |
There was a problem hiding this comment.
The intent of this test is unclear to me. The code compiles fine under the current version of the compiler.
There was a problem hiding this comment.
This test protected me from accidentally adding an alias to the type. Two of my attempts to fix the error message mentioned in the TODO above passed all other tests but failed to compile the standard library.
Previously, the
assugar allowed unsafe captures throughconsume !, which could perform forbidden refcap conversion.closes #1979