-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex match iterator #2109
Merged
Merged
Add regex match iterator #2109
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
class MatchIterator is Iterator[Match] | ||
""" | ||
MatchIterator allows for calling code to repeatedly perform the same match | ||
against a subject string as an iterator. This lets callers repeat the match | ||
until no more matches exist. | ||
""" | ||
let _regex: Regex box | ||
let _subject: String | ||
var _offset: USize = 0 | ||
|
||
new create(regex': Regex box, subject': String, offset': USize = 0) => | ||
""" | ||
Creates a new Match Iterator from a regular expression and a subject | ||
string. | ||
""" | ||
_regex = regex' | ||
_subject = consume subject' | ||
_offset = offset' | ||
|
||
fun has_next() : Bool => | ||
""" | ||
Indicates whether there is another match available. | ||
""" | ||
try | ||
let m = _regex(_subject, _offset)? | ||
true | ||
else | ||
false | ||
end | ||
|
||
fun ref next(): Match ? => | ||
""" | ||
Yields the next match to the regular expression or produces | ||
an error if there is no match. | ||
""" | ||
let m = _regex(_subject, _offset)? | ||
_offset = m.end_pos() + 1 | ||
m | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,6 +73,13 @@ class Regex | |
|
||
_jit = jit and (@pcre2_jit_compile_8[I32](_pattern, U32(1)) == 0) | ||
|
||
fun matches(subject: String): MatchIterator => | ||
""" | ||
Creates a match iterator from the regular expression that will iterate | ||
over the supplied subject returning matches | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add a period at the end of this sentence? |
||
""" | ||
MatchIterator(this, subject) | ||
|
||
fun eq(subject: ByteSeq box): Bool => | ||
""" | ||
Return true on a successful match, false otherwise. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This little symbol on GitHub is indicating that this file is missing an empty line at the end of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the little symbol, and there is a line at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's odd - it may be indicating that there is extra whitespace on the line at the end of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means "there's no newline at the end of the file".