Fix empty string serialisation #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in how empty strings are serialised. Resolves ponylang#2245.
|
Im going to merge this so I can do a release to get those of us over at WallarooLabs moving again. @Praetonus if there's a change to the implementation approach you would like to make, have at it. |
SeanTAllen
added a commit
that referenced
this pull request
Sep 24, 2017
That I forgot to add changelog label to before merging
This was referenced Sep 24, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in how empty strings are serialised.
Resolves #2245.
This PR is based on @Praetonus's PR #2246 and includes the codegen test he added. It is an implementation of the diff I suggested in my comment on that PR.