Fix compiler crash on case methods with _ as a method parameter.
#2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was failing for _ as a case method argument
mfelsche
added
the
changelog - fixed
jemc
changed the title
_ as a method parameter.
|
I made a small formatting change, and changed the PR title to make a clearer changelog entry. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was failing for
_as a case method argument.Case method docstrings contain the signature and docstrings of each case method concatenated.
The method of printing the signature didn't work for
_, the dont care symbol.With this PR it still won't print every possible expression correctly (e.g. recover expressions) but it won't fail anymore.
This fixes #2249.