Fix codegen ordering of implicit finalisers #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that all implicit finalisers are correctly registered before generating user functions. This ensures that every type with an implicit finaliser is correctly recognised as such when generating object allocations. This doesn't contain a test case because the bug occurs because of the non-deterministic iteration of the reachability map.
Praetonus
added
the
changelog - fixed
jemc
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all implicit finalisers are correctly registered before generating user functions. This ensures that every type with an implicit finaliser is correctly recognised as such when generating object allocations.
This doesn't contain a test case because the bug occurs because of the non-deterministic iteration of the reachability map.