Support setting the binary executable name with --bin-name.
#2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
reviewed
Dec 18, 2017
There was a problem hiding this comment.
This is a great addition, but I'm unsure about calling the option --exe-name / -e.
I think my preference would be to call it --bin-name / -b and make the help text say "executable binary" instead of just "executable".
My reasoning is that when I see exe in the source code / help text my first thought was that this was a windows-specific option relating to .exe files. So I worry about --exe-name causing undue confusion for unix users.
@jemc made a [good suggestion](ponylang#2430 (review)) to use --bin-name and -b instead of --exe-name and -e.
jemc
changed the title
--bin-name.
jemc
added
the
changelog - added
|
Thanks! |
ponylang-main
added a commit
that referenced
this pull request
Dec 19, 2017
slayful
pushed a commit
to slayful/ponyc
that referenced
this pull request
Dec 20, 2017
Support setting the binary executable name with `--bin-name`.
slayful
pushed a commit
to slayful/ponyc
that referenced
this pull request
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.