Add the pony_try function to receive Pony errors in C code #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
added
the
changelog - added
jemc
reviewed
Dec 29, 2017
test/libponyrt/lang/except.cc
Outdated
|
|
||
| #include <pony.h> | ||
|
|
||
| TEST(ExceptTest, PonyTry) |
There was a problem hiding this comment.
No particular reason. I'll update.
jemc
approved these changes
Jan 4, 2018
|
The Linux and OSX builds seem to be passing. I tried to update the wscript file with a custom build rule for |
This function is implemented in LLVM IR since it cannot be implemented in C. This change also exposes the `pony_error` function (renamed from `pony_throw`) in the public runtime interface in order to allow C programs to both raise and receive Pony errors.
|
I'll take a look tonight. |
|
It looks like my last change fixed the problem. It was a naming error (I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is implemented in LLVM IR since it cannot be implemented in C.
This change also exposes the
pony_errorfunction (renamed frompony_throw) in the public runtime interface in order to allow C programs to both raise and receive Pony errors.@sylvanc @SeanTAllen @jemc This PR adds the first instance of handwritten LLVM IR to the project. It'll almost certainly not become a trend since there aren't a lot of things that cannot be done in C, but it will nonetheless add some maintenance burden given that LLVM IR sometimes has breakages, so I'd like you to sign off on this.
@kulibali I'm not sure how to update the Windows build system for that one. We'd basically need to add a custom rule when compiling
.llfiles forlibponyrt, but keep the existing rule for.cand.ccfiles. That existing rule seems to be internal to waf so I'm not sure how to proceed. The build command for.llfiles would bellc.exe -filetype=obj -o file.o file.ll. Could you take a look when you have time?