Compile error when comparing sugared constructors with 'is' or 'isnt' (#2024) #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error in Windows compilation: |
SeanTAllen
reviewed
Jan 15, 2018
src/libponyc/pass/refer.c
Outdated
| type = ast_data(ast); | ||
| if(ast_id(type) != TK_PRIMITIVE) | ||
| { | ||
| ast_error(opt->check.errors, ast, "comparing a non-primitive type constructor will always fail"); |
There was a problem hiding this comment.
This is a good error message except I think the folks who are most likely to trigger it might not realize they are doing "as" against a constructor even when they see the error.
There was a problem hiding this comment.
Good point, changed it. Hopefully it's clearer now.
Praetonus
reviewed
Jan 17, 2018
| @@ -1334,6 +1378,8 @@ ast_result_t pass_refer(ast_t** astp, pass_opt_t* options) | |||
| case TK_ERROR: r = refer_error(options, ast); break; | |||
| case TK_COMPILE_ERROR: | |||
| r = refer_compile_error(options, ast); break; | |||
| case TK_IS: | |||
There was a problem hiding this comment.
This should cover TK_ISNT as well.
|
When we add support for |
…#2024) An identity comparison with a new object will always be false, so this will catch mistaken 'is' comparisons without affecting legitimate uses.
|
Oops. Added the TK_ISNT case. |
Praetonus
approved these changes
Jan 17, 2018
|
CI failure is just Travis macos glitching out. Going to merge this. |
jemc
added
the
changelog - added
jemc
changed the title
ponylang-main
added a commit
that referenced
this pull request
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2024
Compile error when using 'is' to compare sugared type constructors, including cases where they are embedded in tuples or seqs.
I didn't include array literals in these changes, but I think those could also be an issue. For example,
[1; 2; 3] is [1; 2; 3]is false, which could cause the same kind of confusion.