Ensure ASIO thread cannot be stopped prematurely #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was possible for the ASIO thread to be stopped in anticipation of runtime termination when runtime termination didn't actually occur. This would leave the runtime in an invalid state where a new ASIO thread would need to be restarted. This commit changes the behavior to ensure that the ASIO thread is only stopped when the runtime is about to be terminated to ensure the runtime cannot be in an invalid state where the ASIO thread isn't running.
jemc
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Mar 28, 2018
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Prior to this commit, it was possible for the ASIO thread to be stopped in anticipation of runtime termination when runtime termination didn't actually occur. This would leave the runtime in an invalid state where a new ASIO thread would need to be restarted. This commit changes the behavior to ensure that the ASIO thread is only stopped when the runtime is about to be terminated to ensure the runtime cannot be in an invalid state where the ASIO thread isn't running.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was possible for the ASIO thread to
be stopped in anticipation of runtime termination when runtime
termination didn't actually occur. This would leave the runtime
in an invalid state where a new ASIO thread would need to be
restarted.
This commit changes the behavior to ensure that the ASIO thread
is only stopped when the runtime is about to be terminated to
ensure the runtime cannot be in an invalid state where the ASIO
thread isn't running.