Fix tuple pattern matching issue where only some elements would violate caps. #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pattern-matching tuples that have the same number of elements, ponyc was treating the entire match as violating capabilities when only one of the elements was violating. In truth we should be able to recognize that tuples are distinct from the other elements. This patch fixes `is_tuple_match_tuple` to return MATCHTYPE_REJECT as soon as any pairwise element comparison returns MATCHTYPE_REJECT. The fix was pinpointed by @Praetonus when I discussed this issue with him.
jemc
added
the
changelog - fixed
|
For reference, here's my example that was failing to compile: |
jemc
changed the title
Praetonus
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Looks good to me.
In the future, we might want to extend this so that even if a previous element is denied, we continue to iterate to see if another element is rejected and should take precedence.
It would require changes to code generation when matching on values, as we must check the potentially denied element(s) last.
ponylang-main
added a commit
that referenced
this pull request
Apr 19, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
…ps. (ponylang#2658) When pattern-matching tuples that have the same number of elements, ponyc was treating the entire match as violating capabilities when only one of the elements was violating. In truth we should be able to recognize that tuples are distinct from the other elements. This patch fixes `is_tuple_match_tuple` to return MATCHTYPE_REJECT as soon as any pairwise element comparison returns MATCHTYPE_REJECT. The fix was pinpointed by @Praetonus when I discussed this issue with him.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pattern-matching tuples that have the same number of elements,
ponyc was treating the entire match as violating capabilities when
only one of the elements was violating. In truth we should be able
to recognize that tuples are distinct from the other elements.
This patch fixes
is_tuple_match_tupleto return MATCHTYPE_REJECTas soon as any pairwise element comparison returns MATCHTYPE_REJECT.
The fix was pinpointed by @Praetonus when I discussed this issue with
him.