Compute File.writeable based on FileWrite instead of FileRead. #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`File._descriptor(...)` was computing the `writeable` flag by checking if the `FileRead` capability was set, rather than the `FileWrite` capability.
jemc
added
the
changelog - fixed
jemc
changed the title
jemc
approved these changes
May 11, 2018
`try ... then ... end` can mask errors and give a false positive to tests.
Space after : before type.
|
Hi @sgebbie , this one if failing on OSX with the following logs: |
|
restarted the job that fails, lets see if this works now. |
|
@mfelsche Thanks for restarting the job. Now that the directory change is merged, it looks like this is behaving correctly. |
ponylang-main
added a commit
that referenced
this pull request
May 16, 2018
|
Thanks for your work on this! This is highly appreciated :) |
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
…ang#2698) * Compute File.writeable based on FileWrite `File._descriptor(...)` was computing the `writeable` flag by checking if the `FileRead` capability was set, rather than the `FileWrite` capability. * Catch "inner" errors in the writeable test. `try ... then ... end` can mask errors and give a false positive to tests. * Tidy code style to comply with stdlib guidelines. Space after : before type.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File._descriptor(...)was computing thewriteableflag by checkingif the
FileReadcapability was set, rather than theFileWritecapability.