Relax ProcessMonitor checks for execute bits #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strmpnk the commit history on this is messed up |
This is part one of addressing issue ponylang#2714. We avoid breaking compatibility with the API in this change. We should rely on the system to do these checks properly. Since we don't currently have a clean way to signal failure of execv, we'll assert that the path is a proper file first.
cararemixed
force-pushed
the
relax-procmon-exec
branch
from
a848a8a
to
65e9d04
Compare
|
I think I had a tagged checked out before doing this and forgot to reset my branch point to something sane. It should be fixed now. |
|
@strmpnk should this go in changelog? if yes, in "Fixed"? its not a breaking change so i'd like to avoid "changed" |
|
This first part is non-breaking. So I'd say fixed makes sense. I'm new to the changelog policy here but should I update this PR with an entry? |
|
@strmpnk you can or for most we use the tags. which i just added. we have a bot that will add the correct changelog entry for you. same as wallaroo labs (ponylang is where wl took the code from) |
SeanTAllen
added
the
changelog - fixed
jemc
approved these changes
May 25, 2018
|
Excellent first commit @strmpnk. Thanks! and welcome to the contributors list. |
ponylang-main
added a commit
that referenced
this pull request
May 26, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one of addressing issue #2714. We avoid breaking compatibility with the API in this change.
We should rely on the system to do these checks properly. Since we don't currently have a clean way to signal failure of execv, we'll assert that the path is a proper file first.