Fix collections/persistent/Lists.from() to return elements in the correct order
#2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect order This change fixed `Lists.from()`, which returned a reversed list, and the associated test, which didn't actually call it. The change also changes `apply()` to use `from()` so as to have a single implementation of making a list from a sequence.
mfelsche
approved these changes
Jun 6, 2018
chalcolith
added
the
changelog - fixed
|
Is there a test we can add for this? I'd like to see a test before we merge. |
|
There already was a test, but it didn't actually call |
|
Yeah I missed that. |
ponylang-main
added a commit
that referenced
this pull request
Jun 6, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 7, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
Lists.from(), which returned a reversed list, and the associated test, which didn't actually call it.The change also changes
apply()to usefrom()so as to have a single implementation of making a list from a sequence.