Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 55] Remove package net/http from stdlib #2795

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

mfelsche
Copy link
Contributor

The net/http package has already been moved to https://github.com/ponylang/http so it can be safely removed
from the stdlib to execute RFC 55.

HTTP examples have also been removed.

The net/http package has already been moved to https://github.com/ponylang/http so it can be safely removed
from the stdlib to execute RFC 55.

HTTP examples have also been removed.
@mfelsche mfelsche requested a review from SeanTAllen June 16, 2018 20:54
@SeanTAllen
Copy link
Member

@mfelsche can you add release notes for this to PR before its merged as this is a breaking change.

@SeanTAllen SeanTAllen added do not merge This PR should not be merged at this time changelog - changed Automatically add "Changed" CHANGELOG entry on merge labels Jun 16, 2018
@mfelsche
Copy link
Contributor Author

Release notes draft

The net/http package has been removed from the stdlib, with it the HTTPClient, HTTPServer and URL classes. They now live in the http package and can be included using stable by adding them to your bundle.json like so:

stable add github ponylang/http --tag 0.1.0

The code in the new repository at version 0.1.0 is exactly the same as it was when it was removed from stdlib. Thus the only change you need to do is to change your imports from use "net/http" to use "http".

@mfelsche mfelsche removed the do not merge This PR should not be merged at this time label Jun 18, 2018
@SeanTAllen SeanTAllen merged commit a32718f into master Jun 18, 2018
@SeanTAllen SeanTAllen deleted the rfc55-remove-http branch June 18, 2018 13:49
ponylang-main added a commit that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants