-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved CHAMP map #2894
Improved CHAMP map #2894
Conversation
The new benchmarks are showing a slight improvement on lookup, and a larger improvement for iteration. However, there is a concerning increase in update times. Old HashMap:
New HashMap:
|
@SeanTAllen done and done |
Merged! |
@Theodus can you add release notes for this? |
It should be noted that this also affects the persistent Set as it is based on HashMap |
Realease NotesThe persistent HashMap and HashSet have reduced memory consumption and improved iteration performance. This change also includes a bug fix related to searching for nonexistent entries and incorrect CHAMP compression. |
This PR includes modifications to the persistent hash map which have also resulted in a fix for #2866. The improvements include removing the
U8
level field from all nodes and applying full CHAMP compression to the entries at each node.