Make _SignedInteger and _UnsignedInteger public #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to enable use of shl/shr and other methods specialized for signed and unsigned integers in a generic context (e.g. for code handling all kinds of signed ints).
mfelsche
added
the
changelog - changed
jemc
added
changelog - added
|
I've changed the label from "changed" to "added". Making a type public that was previously private is like adding that type to the public contract. Also, in semantic versioning terms, this is not a breaking change, as the "changed" label is meant to imply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to enable use of shl/shr and other methods specialized for signed and unsigned integers in a generic context (e.g. for code handling all kinds of signed ints).
This fixes #2390