Add SSL tests and fix some SSL related bugs #3174
Conversation
| if @BIO_ctrl_pending[USize](_input) > 0 then | ||
| read(expect) | ||
| else | ||
| ifdef "openssl_1.1.x" then |
There was a problem hiding this comment.
this is openssl 1.1 specific? what did they change that requires this?
There was a problem hiding this comment.
Yes, SSL_has_pending is new in 1.1. This mailing list post has a good description of what it is for: https://mta.openssl.org/pipermail/openssl-users/2017-January/005110.html
There was a problem hiding this comment.
Could you add a link to that in the code? I think it would be quite handy in the future.
|
There's an issue open for adding some SSL tests, does this resolve it? |
I'm not aware of the issue, but yes, this PR resolves the issue as long as there was nothing else in scope. |
|
@dipinhora i was thinking of #1510 and the corresponding issue #1308. |
|
Seems to be a windows issue @dipinhora |
This commit adds SSL tests for expect, writev, mute, unmute, and throttle. As part of adding these tests, some bugs were encountered and fixed to get the tests to pass.
If, for some reason, TCPConnection is asked to send a 0 byte payload, don't send it. It is wasteful and the Windows code around read/write completion doesn't like it (it registers as an error which results in the connection being closed).
|
Thanks @dipinhora |
This commit adds SSL tests for expect, writev, mute, unmute, and
throttle. As part of adding these tests, some bugs were encountered
and fixed to get the tests to pass.