Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static linking issue encountered during stable build #3259

Merged
merged 3 commits into from
Jul 28, 2019

Conversation

dipinhora
Copy link
Contributor

  • Ensure that -latomic comes after -static to fix static linking

  • Allow overriding -fuse-ld command for linking

@dipinhora
Copy link
Contributor Author

@SeanTAllen it would be ideal if you were able to test with these changes prior to merging. In my limited testing, when using clang on Alpine you don't need to override the ld used but when using gcc you need to ensure the ld is not gold by using the newly added --link-ldcmd argument to ponyc.

@SeanTAllen
Copy link
Member

@dipinhora what should the --link-ldcmd be when used with gcc?

@dipinhora
Copy link
Contributor Author

@SeanTAllen depends on your environment. Most have bfd (the thing that gold superseded). Or you can try lld instead if you have that installed.

@SeanTAllen
Copy link
Member

@dipinhora circleci tests arent running for some reason for this PR (and for your last one). Not sure why.

@dipinhora
Copy link
Contributor Author

@SeanTAllen they're running. They are linked to my personal circleci account setup so they don't show on the PR. It's very annoying actually.

@SeanTAllen
Copy link
Member

@dipinhora that's weird and new. @EpicEric opened a PR earlier from a forked repo and it showed up here.

@dipinhora
Copy link
Contributor Author

@SeanTAllen re: circleci... i was wrong.. they used to run.. now they're stuck with a "needs setup" (see: https://circleci.com/gh/dipinhora/workflows/ponyc). Very annoying.

I'll do a force push to get circleci to pick it up as part of the PR so it works correctly I hope.

@SeanTAllen
Copy link
Member

@dipinhora you might need to turn on using version 2.1/pipeline features under advanced settings for them to work.

@dipinhora
Copy link
Contributor Author

@SeanTAllen re: PRs from other folks. It depends on whether they have circleci setup to do their own personal building outside of the ponylang PRs or not. It's a very annoying quirk.

@dipinhora
Copy link
Contributor Author

@SeanTAllen is this error (https://circleci.com/gh/dipinhora/ponyc/9449; note, this is on a test branch) expected after turning on the pipeline feature thing?

@SeanTAllen
Copy link
Member

@dipinhora you'll apparently need to turn on the orb feature as well. For the ponylang org, its under the org settings under "Security".

@dipinhora
Copy link
Contributor Author

@SeanTAllen new error: https://circleci.com/gh/dipinhora/ponyc/9451. I think I'm going to delete the ponyc project from my circleci config so PRs work again and maybe figure this out at some point in the future.

@dipinhora
Copy link
Contributor Author

@SeanTAllen it seems my deleting ponyc from circleci fixed the PR circleci not building issue.

@dipinhora
Copy link
Contributor Author

@SeanTAllen nevermind. spoke too soon. any idea how to fix that error?

@SeanTAllen
Copy link
Member

Thanks @dipinhora

@SeanTAllen SeanTAllen merged commit 3c45f1d into ponylang:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants