Renamed --ponythreads to ponymaxthreads, fixes #3318

[alexsnaps]

I think fixes #3318

But this also means specifying --ponythreads would be silently ignored:

./helloworld --ponythreads=1              
Hello, world.
$ ./helloworld --ponythreads=0   
Hello, world.
$ ./helloworld --ponymaxthreads=1
Hello, world.
$ ./helloworld --ponymaxthreads=0
--ponymaxthreads can't be less than 1

Should we alias the two? Forbid --ponythreads as an option? Maybe make sure the --pony* "namespace" only contains "known" options? … thinking out loud

[alexsnaps]

If we go for the "namespace concept" should it be more "explicit", e.g. XML like --pony:maxthreads or something? (still thinking out loud)

[SeanTAllen]

@alexsnaps re: namespacing. that needs an RFC.

[SeanTAllen]

--ponythreads shouldn't be aliased. it dies with this change.

[alexsnaps]

I think an RFC might make sense… But could also be a drastic approach to simply "aliasing" or slowly deprecating; e.g. alias first, then print something to stderr, err out and finally go back to this behavior… I'll think it over and might indeed open an RFC. Will refresh my mind again on how other runtime do it…

[SeanTAllen]

We are pre-1.0. Deprecating isn't needed.

[alexsnaps]

--ponythreads shouldn't be aliased. it dies with this change.

If we're all good with this… sure. Don't get me wrong, I'm not against merging it this way (if this PR is all good with reviewers), just thought I'd explicitly mention it

We are pre-1.0. Deprecating isn't needed.

Makes sense!

[alexsnaps]

In any case, this will require https://github.com/ponylang/ponylang-website changes again too.

[SeanTAllen]

@alexsnaps yup. website will need to be updated. good catch. i had forgotten about that, because i am the great forgetter today.

[SeanTAllen]

Thanks @alexsnaps. Can you add release notes to the release issue?

[alexsnaps]

Can you add release notes to the release issue?

Adding them now… will also open a PR against the website repo. Probably only later today (🤞) tho.