Build Docker images for windows builds #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds Dockerfiles and associated GitHub actions to build Windows Docker images for nightlies and releases.
SeanTAllen
added
the
changelog - added
|
Is the plan to update again when there is a ponyup for Windows? |
SeanTAllen
previously requested changes
Apr 6, 2020
|
Yes, these images are for getting Windows CI builds of corral and ponyup working, whereupon they will swallow their own tail and switch to using ponyup. |
|
Now how to figure out how to use Docker for Windows with Windows images on GitHub Actions. (Docker for Windows can either run in Linux mode or Windows mode, but not both, and from these errors it looks like it's running in Linux mode on GitHub Actions.) |
|
I guess I'm mistaken. |
|
FreeBSD check seems spurious. |
|
Is this good to squash and merge? |
|
I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Dockerfiles and associated GitHub actions to build Windows Docker images for nightlies and releases.