Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Makefile lines to re-enable multiple use= options #3637

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

chalcolith
Copy link
Member

When implementing the CMake build system, I missed copying a couple of lines from the old Makefile that meant that you could only specify one use= option when doing make configure on Posix. This change restores those lines, so you can specify multiple options for use, e.g. make configure use=memtrack_messages,address_sanitizer.

When implementing the CMake build system, I missed copying a couple of lines from the old Makefile that meant that you could only specify one `use=` option when doing `make configure` on Posix.  This change restores those lines, so you can specify multiple options for `use`, e.g. `make configure use=memtrack_messages,address_sanitizer`.
@chalcolith chalcolith added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 3, 2020
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3637.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen merged commit ff22a0e into master Sep 4, 2020
@SeanTAllen SeanTAllen deleted the fix_makefile_uses branch September 4, 2020 01:50
github-actions bot pushed a commit that referenced this pull request Sep 4, 2020
github-actions bot pushed a commit that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants