-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soundness problem with Array.chop #3657
Conversation
Hi @jasoncarr0, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
packages/builtin/array.pony
Outdated
|
||
The entry type must be sendable so that the two array pieces can | ||
be deeply isolated from each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could use some elaboration; the example you gave in the issue would be good here as not everyone is going to understand what this means.
.release-notes/3657.md
Outdated
@@ -0,0 +1,14 @@ | |||
## Restrict Array.chop to be used with sendable element types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to be Fix soundness problem with Array.chop
It's a much clearer end user "what was the issue" headline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, changed
Thanks @jasoncarr0. |
While the memory of the two array pieces was disjoint, a non-sendable element type could allow aliases between the two array portions that would violate isolation.
Fixes #3652