Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soundness problem with Array.chop #3657

Merged
merged 6 commits into from
Sep 17, 2020

Conversation

jasoncarr0
Copy link
Contributor

@jasoncarr0 jasoncarr0 commented Sep 16, 2020

While the memory of the two array pieces was disjoint, a non-sendable element type could allow aliases between the two array portions that would violate isolation.

Fixes #3652

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 16, 2020
@ponylang-main
Copy link
Contributor

Hi @jasoncarr0,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3657.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

Comment on lines 444 to 446

The entry type must be sendable so that the two array pieces can
be deeply isolated from each other.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could use some elaboration; the example you gave in the issue would be good here as not everyone is going to understand what this means.

@SeanTAllen SeanTAllen changed the title Restrict Array.chop to allow only sendable element types Fix soundness problem with Array.chop Sep 16, 2020
@jasoncarr0 jasoncarr0 changed the title Fix soundness problem with Array.chop Restrict Array.chop to be used with sendable element types Sep 17, 2020
@SeanTAllen SeanTAllen changed the title Restrict Array.chop to be used with sendable element types Fix soundness problem with Array.chop Sep 17, 2020
@@ -0,0 +1,14 @@
## Restrict Array.chop to be used with sendable element types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to be Fix soundness problem with Array.chop

It's a much clearer end user "what was the issue" headline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, changed

@SeanTAllen
Copy link
Member

Thanks @jasoncarr0.

@SeanTAllen SeanTAllen merged commit 27aacb8 into ponylang:master Sep 17, 2020
github-actions bot pushed a commit that referenced this pull request Sep 17, 2020
github-actions bot pushed a commit that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array.chop can be unsound for non-sendables
4 participants