Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in offset argument to cpointer #3741

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

ergl
Copy link
Member

@ergl ergl commented Apr 8, 2021

No description provided.

@ergl
Copy link
Member Author

ergl commented Apr 8, 2021

@SeanTAllen should this have release notes for the possible memory leak?

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Apr 8, 2021
@SeanTAllen
Copy link
Member

@ergl yes

@ponylang-main
Copy link
Contributor

Hi @ergl,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3741.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen merged commit ef9303d into main Apr 9, 2021
@SeanTAllen SeanTAllen deleted the ergl/fix_cpointer branch April 9, 2021 11:53
github-actions bot pushed a commit that referenced this pull request Apr 9, 2021
github-actions bot pushed a commit that referenced this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants