Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of String.add to String iso^ #3752

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

ergl
Copy link
Member

@ergl ergl commented May 5, 2021

Fixes #3750 by implementing RFC 69.


I've marked this as "do not merge" until other ponylang libraries are updated to deal with this change in a backwards-compatible way (where possible).

@ergl ergl added do not merge This PR should not be merged at this time changelog - changed Automatically add "Changed" CHANGELOG entry on merge labels May 5, 2021
@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label May 5, 2021
@SeanTAllen SeanTAllen merged commit fc688c8 into main May 5, 2021
@SeanTAllen SeanTAllen deleted the ergl/rfc-69 branch May 5, 2021 11:59
github-actions bot pushed a commit that referenced this pull request May 5, 2021
github-actions bot pushed a commit that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Make String.add return String iso^
2 participants