-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify wording for some subtyping errors #3933
Conversation
While the usage of subtyping is technically correct, this makes it clearer why the unaliasing appears (and aliasing in the other formulation), we need need to assign it to a new name for the parameter.
Windows failure can be ignored. It's a CI error that is known and being looked into. |
@jasoncarr0 is this ready other than the request for some release notes? |
Hi @jasoncarr0, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
This addresses my intent with #3928, @jasoncarr0 during sync noted why he didn't think this was a fix. He had an idea for a deeper change where it would point out the variable that needs to be consumed. We discussed and he will be opening an issue for that. Note to self: when squashing this to merge, make sure Fixes #3929 and #3928 is part of the comment. |
@SeanTAllen Is this good to merge? Or is there anything else I missed |
@jasoncarr0 it's fine. in the future you can do one line per paragraph in the release notes. |
A few subtyping errors were technically incorrect, or unnecessarily obtuse. This improves the wording to better clarify the meaning of these.
Fixes #3929 and #3928