Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "nodoc" annotation #3978

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Add "nodoc" annotation #3978

merged 1 commit into from
Feb 1, 2022

Conversation

SeanTAllen
Copy link
Member

The can be used to control the pony compilers documentation generation,
any structure that can have a docstring (except packages) can be
annotated with \nodoc\ to prevent documentation from being generated.

This replaces a hack I put in years ago to filter out items that
were "for testing" by looking for Test and _Test at the beginning of
the name as well as providing UnitTest or TestList.

All standard library test items have been annotated with \nodoc\ to
keep them continuing to not have documentation generated by our
standard process of creating the standard library documentation site.

ponylang org libraries will need to be updated as well.

Note that the "should we include this package" hack to filter out
packages called "test" and "builtin_test" still exists for the time
being until we have further discussion.

Closes #3332

@SeanTAllen SeanTAllen requested a review from a team January 29, 2022 20:51
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Jan 29, 2022
@SeanTAllen
Copy link
Member Author

I've also added a manual CHANGELOG entry to the "changed" aspect of this that removed the previous "sean quick hack" version.

The can be used to control the pony compilers documentation generation,
any structure that can have a docstring (except packages) can be
annotated with \nodoc\ to prevent documentation from being generated.

This replaces a hack I put in years ago to filter out items that
were "for testing" by looking for Test and _Test at the beginning of
the name as well as providing UnitTest or TestList.

All standard library test items have been annotated with \nodoc\ to
keep them continuing to not have documentation generated by our
standard process of creating the standard library documentation site.

ponylang org libraries will need to be updated as well.

Note that the "should we include this package" hack to filter out
packages called "test" and "builtin_test" still exists for the time
being until we have further discussion.

Closes #3332
@SeanTAllen
Copy link
Member Author

Tutorial PR opened:

ponylang/pony-tutorial#493

Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good.

@SeanTAllen SeanTAllen merged commit 3fdddf2 into main Feb 1, 2022
@SeanTAllen SeanTAllen deleted the nodoc-annotation branch February 1, 2022 19:29
github-actions bot pushed a commit that referenced this pull request Feb 1, 2022
github-actions bot pushed a commit that referenced this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing actor in generated documentation
2 participants