Fix incorrect "field not initialized" error with while/else #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
SeanTAllen
force-pushed
the
issue-3283
branch
from
cc8f2ae
to
f7f7baf
Compare
Previously, due to a bug in the compiler's while/else handling code, the
following code would be rejected as not initializing all object fields:
```pony
actor Main
var _s: (String | None)
new create(env: Env) =>
var i: USize = 0
while i < 5 do
_s = i.string()
i = i + 1
else
_s = ""
end
```
This commit fixes while/else handling in `refer_while` so that it matches the
correct logic as seen in `refer_if`.
Partially addresses a series of related bugs in #3283.
SeanTAllen
force-pushed
the
issue-3283
branch
from
f7f7baf
to
e551461
Compare
ergl
approved these changes
Feb 16, 2022
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to a bug in the compile's while/else handling code, the
following code would be rejected as not initializing all object fields:
This commit fixes while/else handling in
refer_whileso that it matches thecorrect logic as seen in
refer_if.Partially addresses a series of related bugs in #3283.