Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ponybench to match standard naming conventions. #4033

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

SeanTAllen
Copy link
Member

No description provided.

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Feb 23, 2022
@SeanTAllen SeanTAllen requested a review from a team February 23, 2022 01:49
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Feb 23, 2022
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 23, 2022
Copy link
Member

@rhagenson rhagenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the release notes repeating the eventually correct "pony_bench" name.

.release-notes/ponybench-rename.md Outdated Show resolved Hide resolved
@SeanTAllen
Copy link
Member Author

@rhagenson i'm not sure what you mean. Can you do a suggested change please?

@rhagenson
Copy link
Member

@SeanTAllen You fixed it already. It was that in the release docs "pony_bench" was being used in the before and after code block informing users how to update their code.

Copy link
Member

@rhagenson rhagenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Feb 23, 2022
@SeanTAllen SeanTAllen merged commit f87574b into main Feb 23, 2022
@SeanTAllen SeanTAllen deleted the ponybench-conform-to-naming branch February 23, 2022 19:34
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 23, 2022
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants