Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PonyCheck to standard library #4034

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Add PonyCheck to standard library #4034

merged 5 commits into from
Feb 24, 2022

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Feb 23, 2022 •
edited
Loading

Closes #4029

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Feb 23, 2022
@SeanTAllen SeanTAllen requested a review from a team February 23, 2022 02:26
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Feb 23, 2022
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 23, 2022
@SeanTAllen SeanTAllen force-pushed the add-ponycheck-to-the-standard-library branch from 2ab93a7 to fce2715 Compare February 23, 2022 02:26
@SeanTAllen
Copy link
Member Author

This needs the PonyTest change to made first (and then this gets rebased).

And there's a bug in LLVM IR creation that is causing the --verify for standard library to fail. That has to be addressed and this will again need to be rebased.

@SeanTAllen SeanTAllen changed the title Add ponycheck to standard library Add PonyCheck to standard library Feb 23, 2022
@SeanTAllen
Copy link
Member Author

Ive updated this to work with PonyTest pre name change, I'll get this merged then update the ponytest name to change the required ponycheck bits.

@SeanTAllen SeanTAllen force-pushed the add-ponycheck-to-the-standard-library branch from d49828f to 02daab5 Compare February 23, 2022 17:21
@SeanTAllen
Copy link
Member Author

We are getting OOM killed on the aarch64 Linux glibc graviton instance while building the standard library tests.

EpicEric
EpicEric suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@EpicEric EpicEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non-extensive list of public-facing documentation changes.

packages/pony_check/property_unit_test.pony Outdated Show resolved Hide resolved
packages/pony_check/property_unit_test.pony Outdated Show resolved Hide resolved
packages/pony_check/property_runner.pony Outdated Show resolved Hide resolved
packages/pony_check/property_runner.pony Outdated Show resolved Hide resolved
packages/pony_check/property_runner.pony Outdated Show resolved Hide resolved
packages/pony_check/ascii_range.pony Outdated Show resolved Hide resolved
packages/pony_check/ascii_range.pony Outdated Show resolved Hide resolved
examples/pony_check/custom_class.pony Outdated Show resolved Hide resolved
examples/pony_check/async_tcp_property.pony Outdated Show resolved Hide resolved
examples/pony_check/README.md Outdated Show resolved Hide resolved
@SeanTAllen
Copy link
Member Author

@EpicEric I got all those merged. phew. what an awful ui.

@EpicEric
Copy link
Contributor

EpicEric commented Feb 23, 2022 •
edited
Loading

I'll give a more thorough review later. If there are several changes I'll commit directly per your suggestion.

@SeanTAllen SeanTAllen force-pushed the add-ponycheck-to-the-standard-library branch from aa2adfd to 1f3bd17 Compare February 23, 2022 19:43
@SeanTAllen
Copy link
Member Author

I rebased this against main to pick up changes and resolve the merge conflict in stdlib/_tests.pony

@SeanTAllen
Copy link
Member Author

@EpicEric let me know when you are feeling good with your edits.

@SeanTAllen
Copy link
Member Author

When @EpicEric signs off, I'll merge this and then rebase the ponytest rename branch against this and update the ponytest usage here to match that forthcoming change.

@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Feb 24, 2022
@SeanTAllen SeanTAllen merged commit f9b837e into main Feb 24, 2022
@SeanTAllen SeanTAllen deleted the add-ponycheck-to-the-standard-library branch February 24, 2022 02:31
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 24, 2022
github-actions bot pushed a commit that referenced this pull request Feb 24, 2022
@ponylang-main
Update CHANGELOG for PR #4034
dd9a871
github-actions bot pushed a commit that referenced this pull request Feb 24, 2022
@ponylang-main
Updates release notes for PR #4034
95716e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpicEric EpicEric EpicEric approved these changes

Assignees
No one assigned
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC 73: Add ponycheck to the standard library
3 participants
@SeanTAllen @EpicEric @ponylang-main