Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-recover constructor expressions #4124

Merged
merged 12 commits into from
Jul 5, 2022
Merged

Auto-recover constructor expressions #4124

merged 12 commits into from
Jul 5, 2022

Commits on May 23, 2022

  1. Autorecover constructor calls in arguments

    @chalcolith
    chalcolith committed May 23, 2022
    Configuration menu
    Copy the full SHA
    60219da View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Auto-recover constructor calls in assignments

    @chalcolith
    chalcolith committed May 24, 2022
    Configuration menu
    Copy the full SHA
    bea586c View commit details
    Browse the repository at this point in the history

  2. Remove leftover unused parameter

    @chalcolith
    chalcolith committed May 24, 2022
    Configuration menu
    Copy the full SHA
    de55261 View commit details
    Browse the repository at this point in the history

  3. Move test to be a runner test

    @chalcolith
    chalcolith committed May 24, 2022
    Configuration menu
    Copy the full SHA
    6656a03 View commit details
    Browse the repository at this point in the history

  4. Add release notes

    @chalcolith
    chalcolith committed May 24, 2022
    Configuration menu
    Copy the full SHA
    bc67a7c View commit details
    Browse the repository at this point in the history

  5. Update .release-notes/4124.md 

    Co-authored-by: Sean T Allen <sean@seantallen.com>
    @chalcolith @SeanTAllen
    chalcolith and SeanTAllen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    8f6f695 View commit details
    Browse the repository at this point in the history

  6. Update .release-notes/4124.md 

    Co-authored-by: Sean T Allen <sean@seantallen.com>
    @chalcolith @SeanTAllen
    chalcolith and SeanTAllen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    1755649 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Fixes from review: 

    - Change the rhs type instead of the lhs type when auto-recovering constructor calls
- Bail out of the auto-recover check early if we don't need to auto-recover.
- Add tests that make sure we still error out when passing non-sendable args to the constructor call we're trying to auto-recover.
    @chalcolith
    chalcolith committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a804a0e View commit details
    Browse the repository at this point in the history

  2. Disallow trying to autorecover to a complex type

    @chalcolith
    chalcolith committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    2c5535c View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Add tests; support val better

    Jason Carr committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    c5113e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Rename parameter

    @chalcolith
    chalcolith committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a53ea16 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'jaoncarr0/702_suggestions' into issue_7… 

    …02_ctor_autorecover
    @chalcolith
    chalcolith committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    8f6d5a1 View commit details
    Browse the repository at this point in the history