Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building the "x86-64-unknown-linux-gnu" ponyc package #4312

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Jan 20, 2023

The "x86-64-unknown-linux-gnu" package was intended to be "generic", however, it is not actually generic. It is a glibc version that is built on "some glibc using Linux" and will work if it is installed on a Linux that is compatible at a library level with the system that we built the package on.

Quite some time ago, Theo and I (who made the initial decision to include a "x86-64-unknown-linux-gnu" package) realized that the
"x86-64-unknown-linux-gnu" package idea was "a very bad idea".

There are a couple large problems with this approach:

1- anyone using the package on glibc distro that isn't library compatible with our "x86-64-unknown-linux-gnu" build will have the installed ponyc fail in interesting and confounding ways. That's a bad user experience.

2- in order to not fall horribly behind, from time to time, we need to "rev" the environment used to build our "x86-64-unknown-linux-gnu" packages. For us that has meant changing the Ubuntu version periodically. That then means that people who had an environment that worked will do an update and install a ponyc that doesn't work because it is for a different set of libraries. That's a bad user experience as well.

This PR drops "x86-64-unknown-linux-gnu" from being built and mirrors a change in ponyup that dropped support for using the package via ponyup. See ponylang/ponyup#245 for more information about the ponyup change.

@SeanTAllen SeanTAllen requested review from chalcolith, mfelsche and a team January 20, 2023 22:33
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 20, 2023
@SeanTAllen SeanTAllen added changelog - changed Automatically add "Changed" CHANGELOG entry on merge and removed discuss during sync Should be discussed during an upcoming sync labels Jan 20, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 20, 2023
@SeanTAllen SeanTAllen marked this pull request as draft January 20, 2023 22:42
The "x86-64-unknown-linux-gnu" package was intended to be "generic", however, it
is not actually generic. It is a glibc version that is built on "some glibc
using Linux" and will work if it is installed on a Linux that is compatible at
a library level withthe system that we built the package on.

Quite some time ago, Theo and I (who made the initial decision to include
a "x86-64-unknown-linux-gnu" package) realized that the
 "x86-64-unknown-linux-gnu" package idea was "a very bad idea".

There are a couple large problems with this approach:

1- anyone using the pacakge on glibc distro that isn't library compatible with
our "x86-64-unknown-linux-gnu" build will have the installed ponyc fail in
interesting and confounding ways. That's a bad user experience.

2- in order to not fall horribly behind, from time to time, we need to
"rev" the environment used to build our "x86-64-unknown-linux-gnu" packages.
For us that has meant changing the Ubuntu version periodically. That then means
that people who had an environment that worked will do an update and install
a ponyc that doesn't work because it is for a different set of libraries.
That's a bad user experience as well.

This PR drops "x86-64-unknown-linux-gnu" from being built and mirrors a change
in ponyup that dropped support for using the package via ponyup. See
ponylang/ponyup#245 for more information about the
ponyup change.
@SeanTAllen SeanTAllen marked this pull request as ready for review January 20, 2023 22:44
@SeanTAllen SeanTAllen merged commit 7f25f8d into main Jan 24, 2023
@SeanTAllen SeanTAllen deleted the no-more-generic-gnu branch January 24, 2023 19:09
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 24, 2023
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants