Make sure the test runner gets rebuilt whenever ponyc gets rebuilt #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a call to `make build` would not rebuild the test `runner` whenever `ponyc` would get rebuilt. This could cause some confusion, especially if `libponyrt` changed, as one would expect `make build` to ensure the `runner` is built using the latest version of the runtime and compiler. This commit ensures that the runner will get rebuilt whenever `ponyc` gets rebuilt by adding `ponyc` as an explicit dependency to the `runner` build command.
ponylang-main
added
the
discuss during sync
jemc
approved these changes
Jul 7, 2023
|
The CI failure is unrelated and will be fixed by PR #4358. |
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a call to
make buildwould not rebuild the testrunnerwheneverponycwould get rebuilt. This could cause some confusion, especially iflibponyrtchanged, as one would expectmake buildto ensure therunneris built using the latest version of the runtime and compiler.This commit ensures that the runner will get rebuilt whenever
ponycgets rebuilt by addingponycas an explicit dependency to therunnerbuild command.