Fix for running tests with use= flags enabled
#4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
|
I don't feel qualified to comment on CMake improvements, so I'm requesting review from @chalcolith. |
|
@dipinhora can you rebase this against main? |
Prior to this commit, running `make test` after running `make configure use=use_flag` would fail because the `Makefile` would look for the test binaries in the wrong directory (i.e. in `build/debug` instead of `build/debug-runtimestats`). This commit updates the `Makefile` to try and determine the `use` output directory from the CMake configure generated `cmake_install.cmake` file so that tests can be run successfully. It will fall back to the current behavior and use the default build directory if it the file doesn't exist or it is unable to extract the directory path.
done |
chalcolith
approved these changes
Jul 11, 2023
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, running
make testafter runningmake configure use=use_flagwould fail because theMakefilewould look for the test binaries in the wrong directory (i.e. inbuild/debuginstead ofbuild/debug-runtimestats).This commit updates the
Makefileto try and determine theuseoutput directory from the CMake configure generatedcmake_install.cmakefile so that tests can be run successfully. It will fall back to the current behavior and use the default build directory if it the file doesn't exist or it is unable to extract the directory path.