Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing "runtime_info" package documentation #4476

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

SeanTAllen
Copy link
Member

It wasn't being built as part of testing/documentation for standard library.

@SeanTAllen SeanTAllen requested a review from a team January 5, 2024 20:21
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 5, 2024
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jan 5, 2024
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4476.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the fix-missing-docs branch 2 times, most recently from 648ee4b to 45d9c9f Compare January 5, 2024 21:30
It wasn't being built as part of testing/documentation for standard
library.
@SeanTAllen SeanTAllen marked this pull request as draft January 5, 2024 22:00
@SeanTAllen SeanTAllen marked this pull request as ready for review January 5, 2024 22:05
Copy link
Member

@rhagenson rhagenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SeanTAllen SeanTAllen merged commit 161b5ab into main Jan 7, 2024
23 checks passed
@SeanTAllen SeanTAllen deleted the fix-missing-docs branch January 7, 2024 15:13
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 7, 2024
github-actions bot pushed a commit that referenced this pull request Jan 7, 2024
github-actions bot pushed a commit that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants