Add a size limit to font_matches_cache and empty it when it's reached
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is another source of leakage with that stress test when a software renderer is involved. That one should be fixed by iced-rs/iced#2210. |
jackpot51
reviewed
Jan 24, 2024
jackpot51
reviewed
Jan 24, 2024
In `FontSystem`, `font_matches_cache` is an ever growing cache.
It can also be a fast growing one in stress tests like running this
in `cosmic-term`:
mpv -speed 3 -vo tct <some_video>
So this commit adds a size limit to that cache, and clears the cache
when that limit is reached, which shouldn't be a common occurrence in
normal usage.
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
MoSal
force-pushed
the
matches_cache_limit
branch
from
8544f00 to
7d2e8bb
Compare
`Attrs` contains info like color and metadata which are not relevant to font matching. So, add a new struct `FontMatchAttrs` which only contains the relevant info, and use it as a key in `FontSystem`'s `font_matches_cache`. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
jackpot51
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
FontSystem,font_matches_cacheis an ever growing cache.It can also be a fast growing one in stress tests like running this
in
cosmic-term:So this commit adds a size limit to that cache, and simply empties
it when that limit is reached, which shouldn't be a common occurrence
in normal usage.