-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binder
and ashmem
kernel modules
#173
Comments
considering upstream dropped ashmem in favor of memfd since 5.18, i think people shouldn't use anbox anymore. So just binderfs should be enough |
@SkyfallWasTaken could you test 2 things for me?
|
No, sorry, it errors with this:
It's worth noting that Pop!_OS updates the kernel faster than Ubuntu does (It's on 6.0.2 now instead of the previous 5.18) |
that's fine that repo is a fork of one that is independent of distros, i might have messed up somewhere then hmmm |
ah i think i found it, @SkyfallWasTaken can you try assuming you didn't undo the changes, basically
|
Sorry, the dkms command has still got the same error:
|
well darn it, i'll look deeper into it when i have the time |
[ Upstream commit 5d7bebf ] If transport_add_device() fails in sas_phy_add(), the kernel will crash trying to delete the device in transport_remove_device() called from sas_remove_host(). Unable to handle kernel NULL pointer dereference at virtual address 0000000000000108 CPU: 61 PID: 42829 Comm: rmmod Kdump: loaded Tainted: G W 6.1.0-rc1+ #173 pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : device_del+0x54/0x3d0 lr : device_del+0x37c/0x3d0 Call trace: device_del+0x54/0x3d0 attribute_container_class_device_del+0x28/0x38 transport_remove_classdev+0x6c/0x80 attribute_container_device_trigger+0x108/0x110 transport_remove_device+0x28/0x38 sas_phy_delete+0x30/0x60 [scsi_transport_sas] do_sas_phy_delete+0x6c/0x80 [scsi_transport_sas] device_for_each_child+0x68/0xb0 sas_remove_children+0x40/0x50 [scsi_transport_sas] sas_remove_host+0x20/0x38 [scsi_transport_sas] hisi_sas_remove+0x40/0x68 [hisi_sas_main] hisi_sas_v2_remove+0x20/0x30 [hisi_sas_v2_hw] platform_remove+0x2c/0x60 Fix this by checking and handling return value of transport_add_device() in sas_phy_add(). Fixes: c7ebbbc ("[SCSI] SAS transport class") Suggested-by: John Garry <john.g.garry@oracle.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20221107124828.115557-1-yangyingliang@huawei.com Reviewed-by: John Garry <john.g.garry@oracle.com> Reviewed-by: Jason Yan <yanaijie@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
|
@SkyfallWasTaken can you confirm? |
@Fuseteam Unfortunately, I no longer use Linux, so I can't test this out. Sorry :( |
Ah no worries |
Most Ubuntu-based distros ship the
binder
andashmem
kernel modules. However, Pop!_OS does not. These modules are required for Android emulators, such as Anbox (which requires binder and ashmem) and Waydroid (which only requires binder). I did find two issues about this (#113 and #39) but they suggest installing a new kernel, which I don't really feel comfortable with.The text was updated successfully, but these errors were encountered: