Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension Hiding System #82

Merged
merged 23 commits into from
May 26, 2021
Merged

Dimension Hiding System #82

merged 23 commits into from
May 26, 2021

Conversation

EMREOYUN
Copy link
Contributor

@EMREOYUN EMREOYUN commented May 12, 2021

WARNING: Before commiting, please test these commits for anything can cause bug or unintended results. This commit has been tested at 12/05/2021 14:03 GMT

Requested at #75, Dimension hiding system is done and currently working.
Here is how it works:

  • Basically there is boolean "hidden" setting at all dimensions in config.
  • When it is set to true, the dimension will not shown up in /dimensions list(even hidden in the server list shows on kicked) but typing exact server name still passes you to hidden server.
  • When it is set to false, the dimension will shown up in /dimensions as normal and players still can go there.
  • Using /who command will also count players in hidden Dimensions.

Sorry about Merge Pull Requests, my Git app refused to login this account and i updated everything in Web Browser.
You can look final changes at "Files changed" tab.

Hidden setting added to config
Update config.js.example
Server hide function added
Hidden server function added
Hidden value added. This value is unused but without it, TypeScript refuses to build that code.
Update clientcommandhandlerspec.ts
Update clientcommandhandler.ts
Update terrariaserver.ts
Update terrariaserverpackethandler.ts
Wrong location fixed
app/node_modules/dimensions/clientcommandhandler.ts Outdated Show resolved Hide resolved
UpdateTypes.md Outdated Show resolved Hide resolved
Fixed If statement location
config.js.example Outdated Show resolved Hide resolved
@popstarfreas
Copy link
Owner

I'll finish reviewing this this next weekend which is when I will be free next

@EMREOYUN
Copy link
Contributor Author

Alright, thank you letting know. Take your time :)

@popstarfreas popstarfreas merged commit a970d85 into popstarfreas:dev May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants