Email Notification Not Always Being Sent To Users After Admin Permissions Update

[aaronskiba]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
4.1.1+portage-4.1.2

Expected behaviour:
An email should be sent out whenever admin permissions are granted, updated, or revoked for a user.

Actual behaviour:

• Email notifications appear to be sending whenever one or more permissions are removed. However, with respect to adding perms, Perm.use_api is the only one which triggers the email notification.

Relevant Code:

# app/controllers/users_controller.rb
    perms_ids = permission_params[:perm_ids].blank? ? [] : permission_params[:perm_ids].map(&:to_i)
    perms = Perm.where(id: perms_ids)
    privileges_changed = false
    current_user.perms.each do |perm|
      if @user.perms.include? perm
        unless perms.include? perm
          @user.perms.delete(perm)
          @user.remove_token! if perm.id == Perm.use_api.id
          privileges_changed = true
        end
      elsif perms.include? perm
        @user.perms << perm
        if perm.id == Perm.use_api.id
          @user.keep_or_generate_token!
          privileges_changed = true
        end
      end
    end

    if @user.save
      if privileges_changed
        deliver_if(recipients: @user, key: 'users.admin_privileges') do |r|
          UserMailer.admin_privileges(r).deliver_now
        end
      end

[lagoan]

Related to #835