Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Terms of Use and Privacy Policy Translations #429

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

aaronskiba
Copy link
Collaborator

This PR enables translations of the Terms-Of-Use and Privacy-Policy pages.

@github-actions
Copy link

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

@aaronskiba
Copy link
Collaborator Author

Please let me know if you think there's a better or more consistent way to format these sections of text. I used _welcome.html.erb as a reference. However, unlike _welcome.html.erb, no placeholders were needed for formatting in this PR. Because of this, rather than applying format() followed by sanitize(), I thought it might be best to only use sanitize().

Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronskiba aaronskiba merged commit 1fd162b into deployment-portage Sep 5, 2023
@aaronskiba aaronskiba deleted the aaron/issues/388 branch September 5, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants