Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero #624

Open
wants to merge 3 commits into
base: integration
Choose a base branch
from
Open

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero #624

wants to merge 3 commits into from

Conversation

aaronskiba
Copy link
Collaborator

Fixes #607

Changes proposed in this PR:

  • If Rails.configuration.x.plans.default_percentage_answered is non-zero, then the visibility_message prior to this commit does not change. Otherwise, the "You must answer at least 0% of the questions to enable these options." part of the visibility_message is removed.

@aaronskiba
Avoid rendering "You must answer at least 0% ..."
107b8c6 
Add extra handling for set_visibility_info. Only render "You must answer at least %{percentage}%% of the questions" when percentage is a non-zero value.
@aaronskiba
Test set_visibility_info with different percents
d202d49
@aaronskiba
Update CHANGELOG.md
269b41e
@aaronskiba aaronskiba changed the base branch from deployment-portage to integration February 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero
1 participant
@aaronskiba