Enable Various Translations Within /usage Page #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/controllers/usage_controller.rb - Enable date translations when downloading "No. users joined during last year" as well as "No. plans during last year" app/helpers/usage_helper.rb - return translated date from prep_data_for_template_plans_chart() if there is no data - return translated date from prep_date_for_charts() - prep_date_for_charts() is called twice in prep_data_for_template_plans_chart() (this could probably be optimised) app/models/stat_created_plan.rb - Enable date translations when downloading "No. plans by template" app/services/org/monthly_usage_service.rb - Enable date translations for "Download Monthly Usage" .csv file config/locales/ - Added date.formats.month_year_abbr: "%b-%y" for each file spec/ tests - Update usage statistics tests w/ translated dates
app/helpers/usage_helper.rb - This enables translations for the template names listed within the legends for "No. plans by template" and "No. plans created based off your templates" app/views/translation_io_exports/_csv_headers.erb - The segments added to this new file correspond to headers that are generated when downloading usage statistic .csv files. Prior to this commit, none of these segments existed within the translation.io project. lib/csvable.rb - This enables translations for the template names listed as headers when downloading the .csv for "Global usage" as well as "No. plans by template" Add missing csv header segments These segments correspond to generated .csv headers when downloading Usage Statistics. These segments also do not currently exist within translation.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
/usagePage #696Changes proposed in this PR:
NOTE: