Prevent '%{org_title} Plans' Section From Displaying Plans Created by Users From Other Organisations #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`render_respond_to_format_with_error_message` is called both when rescuing from Pundit::NotAuthorizedError and ActiveRecord::RecordNotFound. The method works properly with .html format, but prior to this change, ActionController::UnknownFormat was thrown for .pdf format.
This was
linked to
issues
Apr 26, 2024
Generated by 🚫 Danger |
This commit is intended to patch issue #732 This DMP Assistant fix was implemented in a way to minimise conflicts with the upstream, DMPRoadmap repo. This issue also exists in the upstream repo, so this commit will be readdressed after a fix is implemented there.
aaronskiba
force-pushed
the
aaron/issues/732
branch
from
6213af2 to
502b1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729
Fixes #732
Changes proposed in this PR:
Edit
Plan.organisationally_or_publicly_visible(user)scope to fix Unable to Download Some Organisation Plans on/plansPath #732Add pdf handling in
render_respond_to_format_with_error_messageto fix Add pdf Format Handling Forrender_respond_to_format_with_error_message#729